Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPI] Fix x86 conv2d template when tuning with unpacked layout #5938

Merged
merged 2 commits into from
Jul 2, 2020
Merged

[TOPI] Fix x86 conv2d template when tuning with unpacked layout #5938

merged 2 commits into from
Jul 2, 2020

Conversation

merrymercy
Copy link
Member

@merrymercy merrymercy commented Jun 26, 2020 •
edited
Loading

Fix tuning x86 conv2d and conv2d_transpose with unpacked layout

  • conv2d
    Without this fix, I got
UnboundLocalError("local variable 'oc_bn' referenced before assignment")
  • conv2d_transpose
    Wihtout this fix, I got
IndexError: list index out of range

@merrymercy merrymercy changed the title Fix x86 conv2d template [TOPI] Fix x86 conv2d template when tuning with unpacked layout Jun 26, 2020
@merrymercy
Copy link
Member Author

merrymercy commented Jun 26, 2020 •
edited
Loading

cc @kevinthesun @icemelon9

@merrymercy
Copy link
Member Author

@kevinthesun comments are addressed

@tqchen
Copy link
Member

tqchen commented Jul 1, 2020

@kevinthesun please follow up

kevinthesun
kevinthesun approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesun kevinthesun merged commit 512ed39 into apache:master Jul 2, 2020
@kevinthesun
Copy link
Contributor

Thanks @merrymercy @junrushao1994 @tqchen

@merrymercy merrymercy deleted the pr-fix-x86-conv2d branch July 2, 2020 09:06
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jul 14, 2020
@merrymercy
[TOPI] Fix x86 conv2d template when tuning with unpacked layout (apac…
8d27205 
…he#5938)

* fix x86 conv2d and conv2d_transpose template

* address comments
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jul 14, 2020
@merrymercy @trevor-m
[TOPI] Fix x86 conv2d template when tuning with unpacked layout (apac…
d8a4166 
…he#5938)

* fix x86 conv2d and conv2d_transpose template

* address comments
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@kevinthesun kevinthesun kevinthesun approved these changes

Assignees

@kevinthesun kevinthesun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merrymercy @tqchen @kevinthesun @junrushao