[MXNet] Add parser for contrib.box_decode #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-m
force-pushed
the
trevmorr-mx-box-decode
branch
from
bdfcf0b
to
1bac7ed
Compare
|
@icemelon9 @zhiics Could you please review? Thanks! |
zhiics
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
LGTM
@kevinthesun it would be great if you can help take a look as well.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 1, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes TVM's mxnet frontend more compatible with newer GluonCV versions. It maps
contrib.box_decodeback to the elementwise ops it was previously built out of in earlier GluonCV versions.MXNet operator: https://mxnet.incubator.apache.org/api/python/docs/api/ndarray/contrib/index.html#mxnet.ndarray.contrib.box_decode
This operator is used by object detection models generated by newer GluonCV versions (> 0.5.0).
https://github.com/dmlc/gluon-cv/blob/04baf39d2441bd23e7809032718d1d99ac5bb256/gluoncv/nn/coder.py#L283
The importer now maps it back to these ops:
https://github.com/dmlc/gluon-cv/blob/04baf39d2441bd23e7809032718d1d99ac5bb256/gluoncv/nn/coder.py#L285-L301
Also, here is the implementation of MXNet's box decode op:
https://github.com/apache/incubator-mxnet/blob/1ab4c95fd0e6ceccf718df96b4643762bb23227c/src/operator/contrib/bounding_box-inl.h#L981