[topi][relay] Add operation scatter_add to relay, based on scatter implementation. #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
reviewed
Jul 9, 2020
| indices_np = np.random.randint(-dshape[axis], dshape[axis] - 1, ishape).astype("int64") | ||
|
|
||
| ref_res = ref_scatter_add(data_np, indices_np, updates_np, axis) | ||
| # TODO(mbrookhart): expand testing when adding more backend schedules |
There was a problem hiding this comment.
Any chance you got it to work on cuda? I haven't gotten back to this TODO yet :)
There was a problem hiding this comment.
Hi! Unfortunately, no! For the moment, I just need it on CPU ^^ !
|
I got an unexpected error in jenkins: It seems to come from Rust tests. I don't know why. I just rebased the branch to relaunch tests again. |
|
All tests passed, this time ! |
tqchen
approved these changes
Jul 16, 2020
|
Thanks @notoraptor , @mbrookhart ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a pull request to add operation
scatter_addin relay. Code is based on implementation ofscatterpreviously added by @mbrookhart .