-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages in graph tuner, graph runtime, and module loader. #6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure how these errors are in any way related to the changes I've made. |
tqchen
approved these changes
Jul 28, 2020
Thanks @tkonolige ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…er. (apache#6148) * Raise error if no operators are found in GraphTuner * Raise error if key cannot be found in graph runtime inputs * Detailed error message when module loader is not found
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…er. (apache#6148) * Raise error if no operators are found in GraphTuner * Raise error if key cannot be found in graph runtime inputs * Detailed error message when module loader is not found
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…er. (apache#6148) * Raise error if no operators are found in GraphTuner * Raise error if key cannot be found in graph runtime inputs * Detailed error message when module loader is not found
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…er. (apache#6148) * Raise error if no operators are found in GraphTuner * Raise error if key cannot be found in graph runtime inputs * Detailed error message when module loader is not found
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…er. (apache#6148) * Raise error if no operators are found in GraphTuner * Raise error if key cannot be found in graph runtime inputs * Detailed error message when module loader is not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a couple of confusing errors, so I've improved the error messages for them. The error message for loading a module when its TVM is missing the runtime for it was particularly confusing, so I think this should help make it more clear.