Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] pytorch frontend support conv1d #6203

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

xutianming
Copy link
Contributor

I was trying to tune a TextCNN model containing several Conv1D operators in TorchScript format.
image

In current pytorch frontend, Conv1D was converted into Conv2D but corresponding parameters were not adjusted accordingly.

This pull request fixes above problems. I mainly referred to MXNet frontend here

@masahi
Copy link
Member

masahi commented Aug 4, 2020

Thanks, please add a test.

@xutianming
Copy link
Contributor Author

@masahi Tests for conv1d and conv1d_transpose were added.

@masahi masahi merged commit 82610aa into apache:master Aug 5, 2020
@masahi
Copy link
Member

masahi commented Aug 5, 2020

Thanks @xutianming

@xutianming xutianming deleted the torch_conv1d_dev branch August 6, 2020 04:00
wjliu1998 pushed a commit to wjliu1998/incubator-tvm that referenced this pull request Aug 13, 2020
* [Relay] pytorch frontend support conv1d

* add tests for conv1d

Co-authored-by: xutianming.xtm <[email protected]>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* [Relay] pytorch frontend support conv1d

* add tests for conv1d

Co-authored-by: xutianming.xtm <[email protected]>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* [Relay] pytorch frontend support conv1d

* add tests for conv1d

Co-authored-by: xutianming.xtm <[email protected]>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* [Relay] pytorch frontend support conv1d

* add tests for conv1d

Co-authored-by: xutianming.xtm <[email protected]>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
* [Relay] pytorch frontend support conv1d

* add tests for conv1d

Co-authored-by: xutianming.xtm <[email protected]>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
* [Relay] pytorch frontend support conv1d

* add tests for conv1d

Co-authored-by: xutianming.xtm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants