[Frontend][Pytorch]Add Pytorch advanced indexing #6318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwww
reviewed
Aug 21, 2020
| data = inputs[0] | ||
| indices = [] | ||
| max_indices_len = -1 | ||
| for index in inputs[1]: |
There was a problem hiding this comment.
seems these two for loops are able to be merged
There was a problem hiding this comment.
max_indices_len needs to be fetched first.
zhiics
reviewed
Aug 21, 2020
| if index_key in slice_map: | ||
| tmp = slice_map[index_key] | ||
| else: | ||
| tmp = _op.take(tmp, _expr.const(index[i]), axis=0) |
There was a problem hiding this comment.
out of curiosity, would this introduce many take and tile ops?
There was a problem hiding this comment.
In most cases it should be fine, but we can definitely improve it by adding a new topi implementation.
There was a problem hiding this comment.
I am okay with this for now. We can implement a topi op if when perf is not good.
zhiics
approved these changes
Aug 21, 2020
masahi
approved these changes
Aug 22, 2020
|
Thanks @kevinthesun @zhiics @yongwww |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* Add Pytorch advanced indexing * Minor fix for test * Fix for cuda
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* Add Pytorch advanced indexing * Minor fix for test * Fix for cuda
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* Add Pytorch advanced indexing * Minor fix for test * Fix for cuda
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
* Add Pytorch advanced indexing * Minor fix for test * Fix for cuda
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
* Add Pytorch advanced indexing * Minor fix for test * Fix for cuda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Pytorch advanced indexing
aten::indexand also fixes an issue in Pytorch slice mapping.@masahi @yongwww @zhiics