Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests for kvrocks2redis #1338

Closed
1 of 2 tasks
tisonkun opened this issue Mar 20, 2023 · 9 comments · Fixed by #2175
Closed
1 of 2 tasks

Add basic tests for kvrocks2redis #1338

tisonkun opened this issue Mar 20, 2023 · 9 comments · Fixed by #2175
Assignees
Labels
enhancement type enhancement help wanted Good for newcomers

Comments

@tisonkun
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

So that we're sure that the fundamental functions of kvrocks2redis work well.

Solution

@git-hulk I'm still counting on you to understand how to use kvrocks2redis. So that we can add some gocase to cover those usages.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@tisonkun tisonkun added the enhancement type enhancement label Mar 20, 2023
@PragmaTwice PragmaTwice added the help wanted Good for newcomers label Mar 20, 2023
@git-hulk
Copy link
Member

It should be hard to add Go test cases for this tool but can add a fixed dataset to make sure it works well with those data types.

@tisonkun
Copy link
Member Author

@git-hulk That can be the case. But before we dive into the implementation, I suggest we reach a consensus on what fundamental functions of kvrocks2redis are and how a user manually use it.

@git-hulk
Copy link
Member

OK, let me add a how-to-use kvrocks2redis doc first.

@tisonkun
Copy link
Member Author

OK, let me add a how-to-use kvrocks2redis doc first.

@git-hulk do you have a plan or estimate on this ticket?

@git-hulk
Copy link
Member

git-hulk commented Apr 21, 2023

@tisonkun Yes, I wonder if I should refactor this tool since it's NOT easy to maintain now. But I haven't started it yet. Plan to do that at the beginning of May, after I released the first version of the controller: apache/kvrocks-controller#49

@tisonkun
Copy link
Member Author

@git-hulk can you provide some basic how-to-use info here so that I can follow up?

@git-hulk
Copy link
Member

@git-hulk can you provide some basic how-to-use info here so that I can follow up?

Sure, thanks. Sorry for forgetting this, I'll add the how-to-use doc this week first.

@git-hulk git-hulk self-assigned this Aug 6, 2023
@tisonkun
Copy link
Member Author

tisonkun commented Aug 9, 2023

Related to apache/kvrocks-website#138.

@git-hulk
Copy link
Member

git-hulk commented Aug 9, 2023

I also created another issue #1643 to track improvements of kvrocks2redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement help wanted Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants