Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support of the BLMPOP command #1522

Closed
1 of 2 tasks
Tracked by #1512
infdahai opened this issue Jun 27, 2023 · 6 comments · Fixed by #1774
Closed
1 of 2 tasks
Tracked by #1512

Add the support of the BLMPOP command #1522

infdahai opened this issue Jun 27, 2023 · 6 comments · Fixed by #1774
Assignees
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@infdahai
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

This issue considers to support the blmpop command.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@infdahai infdahai added the enhancement type enhancement label Jun 27, 2023
@infdahai infdahai changed the title Add the support of the BLMPOPcommand Add the support of the BLMPOP command Jun 27, 2023
@git-hulk git-hulk added the good first issue Good for newcomers label Jun 27, 2023
@PragmaTwice PragmaTwice added the help wanted Good for newcomers label Jun 27, 2023
@Yangsx-1
Copy link
Contributor

Is it better to implement together with LMPOP?They are very similar.

@xonx4l
Copy link

xonx4l commented Jun 28, 2023

i got a pr for it . PointCloudLibrary/pcl#5754.

@zevin02
Copy link
Contributor

zevin02 commented Jul 13, 2023

please assign to me

@HolyLow
Copy link
Contributor

HolyLow commented Sep 7, 2023

@git-hulk Hello, I've just finished the LMPOP command, and seems this BLMPOP command is quite similar (just adding the Blocking semantic), so maybe you could assign this one to me as well.

@git-hulk
Copy link
Member

git-hulk commented Sep 7, 2023

@HolyLow Sure, thanks for your contribution.

@git-hulk
Copy link
Member

git-hulk commented Sep 7, 2023

@PragmaTwice @torwig We have many blocking commands, so we copy the blocking implementation codes in many places, not sure if we can simplify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants