Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability checks for operations #1752

Closed
3 tasks
Tracked by #1738
Xuanwo opened this issue Mar 24, 2023 · 7 comments · Fixed by #2461
Closed
3 tasks
Tracked by #1738

Add capability checks for operations #1752

Xuanwo opened this issue Mar 24, 2023 · 7 comments · Fixed by #2461
Assignees

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Mar 24, 2023

In #2060, we added a new concept of Capability in operator. So far, we only do checks during integration tests.

In fact, we can do this check in CompleteLayer.

Before we start any operation, we should check the Capability first. If not supported, we should return an unsupported error directly.

Tasks

  • Add capability checks for operations
  • Add strict mode in Operator
  • Add capability checks for OpXxx
    • If strict enabled, return unsupported error if the arg is not supported
@unixzii
Copy link
Contributor

unixzii commented Jun 13, 2023

Hi @Xuanwo, I'd like to explore and implement this feature, can I take it?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 13, 2023

Hi @Xuanwo, I'd like to explore and implement this feature, can I take it?

Thanks a lot! Let me add more context for this issue.

@Xuanwo Xuanwo changed the title Add strict for Operator Add capability checks for operations Jun 13, 2023
@unixzii
Copy link
Contributor

unixzii commented Jun 13, 2023

Sounds great. I will file a draft PR first, and continue to work on it once the design is confirmed by reviewers.

@unixzii
Copy link
Contributor

unixzii commented Jun 15, 2023

The whole story is not yet finished, we still need this issue to track strict mode. @Xuanwo could you reopen it?

@Xuanwo Xuanwo reopened this Jun 15, 2023
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 15, 2023

Hi, @unixzii, Test for gcs failed https://github.com/apache/incubator-opendal/actions/runs/5280208287/jobs/9551992175

Would like to take a look? Thanks in advance.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 15, 2023

Hi, @unixzii, Test for gcs failed https://github.com/apache/incubator-opendal/actions/runs/5280208287/jobs/9551992175

Would like to take a look? Thanks in advance.

Already fixed in #2467

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 20, 2023

Not needed as till not, let's close.

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants