Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/gdrive: Should return Result<Option<String>> in get_file_id_by_path #3235

Closed
Xuanwo opened this issue Oct 7, 2023 · 5 comments · Fixed by #3801
Closed

services/gdrive: Should return Result<Option<String>> in get_file_id_by_path #3235

Xuanwo opened this issue Oct 7, 2023 · 5 comments · Fixed by #3801

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Oct 7, 2023

get_file_id_by_path returns Result<T> unexpected, we should not mix opendal::Error with internal business logic.

@caicancai
Copy link
Member

I want to try it. It seems to be able to help me familiarize myself with the use of rust syntax

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 9, 2023

I want to try it. It seems to be able to help me familiarize myself with the use of rust syntax

Hi, thanks for taking this. This issue requires the developer to have a google drive account and make sure the google cloud platform API Services has been setup correctly: https://developers.google.com/workspace/guides/auth-overview

Are you ready for this?

@caicancai
Copy link
Member

I want to try it. It seems to be able to help me familiarize myself with the use of rust syntax

Hi, thanks for taking this. This issue requires the developer to have a google drive account and make sure the google cloud platform API Services has been setup correctly: https://developers.google.com/workspace/guides/auth-overview

Are you ready for this?

I thought it was just a simple type modification adaptation, it seems that I think it is too simple, is it necessary to judge the specific error exception in gdrive

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 9, 2023

I thought it was just a simple type modification adaptation, it seems that I think it is too simple, is it necessary to judge the specific error exception in gdrive

I'm guessing it's complex. Since you will need to change the internal business logic and make sure it works as expected.

@caicancai
Copy link
Member

I thought it was just a simple type modification adaptation, it seems that I think it is too simple, is it necessary to judge the specific error exception in gdrive

I'm guessing it's complex. Since you will need to change the internal business logic and make sure it works as expected.

sorroy, I give up this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants