Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings: python tests skipping #3536

Closed
Justin-Xiang opened this issue Nov 8, 2023 · 3 comments · Fixed by #3541
Closed

bindings: python tests skipping #3536

Justin-Xiang opened this issue Nov 8, 2023 · 3 comments · Fixed by #3541

Comments

@Justin-Xiang
Copy link
Contributor

I found the test instructions in Python and CONTRIBUTING not working.

when running OPENDAL_MEMORY_TEST=on pytest on my machine, all tests will skip due to this:

@pytest.fixture()
def service_name():
    service_name = os.environ.get("OPENDAL_TEST")
    if service_name is None:
        pytest.skip("OPENDAL_TEST not set")
    return service_name

Instead, one way to run all tests is:
OPENDAL_TEST=fs opendal_fs_root=/tmp pytest -vk test
fs can change to memory or others

@suyanhanx
Copy link
Member

You are right. We recently updated our testing framework and have not updated the documentation. Would you like to submit a PR to update it?

@Justin-Xiang
Copy link
Contributor Author

Sure, I'd like to make a PR for that, also, I found a lot of Bindings Python CI here skipped, is it expected or due to the issue above?

@Xuanwo
Copy link
Member

Xuanwo commented Nov 8, 2023

Bindings Python CI here skipped

Those CI are only triggered while tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants