Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppaftp enforce to use native-tls #3625

Closed
Xuanwo opened this issue Nov 20, 2023 · 1 comment · Fixed by #3760
Closed

suppaftp enforce to use native-tls #3625

Xuanwo opened this issue Nov 20, 2023 · 1 comment · Fixed by #3760

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Nov 20, 2023

We should make it work with rustls by default.

@sd44
Copy link
Contributor

sd44 commented Nov 22, 2023

I tried to finish the work, but failed.

I hope there is still something useful in my failed attempt, which can help other contributors.

bad pr : sd44@3fc1673
error log:

error[E0277]: the trait bound `AsyncRustlsConnector: From<TlsConnector>` is not satisfied
   --> core/src/services/ftp/backend.rs:244:21
    |
244 |                     AsyncRustlsConnector::from(TlsConnector::from(confi...
    |                     ^^^^^^^^^^^^^^^^^^^^ the trait `From<TlsConnector>` is not implemented for `AsyncRustlsConnector`
    |
    = help: the trait `From<async_tls::connector::TlsConnector>` is implemented for `AsyncRustlsConnector`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `opendal` (lib) due to previous error

And tls auth may have some specific and necessary configurations. How and where to construct these configurations may also be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants