Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: kv adapter's scan should return an iterator or stream instead #3639

Closed
Xuanwo opened this issue Nov 21, 2023 · 2 comments · Fixed by #5208
Closed

idea: kv adapter's scan should return an iterator or stream instead #3639

Xuanwo opened this issue Nov 21, 2023 · 2 comments · Fixed by #5208

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Nov 21, 2023

We return Vec<String> to make it simple, but in some usecases, users doen't want to have the whole content.

@suyanhanx
Copy link
Member

Like the reader, with poll based?

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 21, 2023

Like the reader, with poll based?

Maybe use async_trait is enough since we won't expose them as public API. After we bump to rust 1.74, we can use async in trait directly without async_trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants