services/azfile: azfile doesn't work if root starts with /

[Xuanwo]

For example, if we set root to /opendal/, azfile will return error:

---- behavior::test_stat_dir ----
test panicked: write must succeed: Unexpected (persistent) at create_dir => failed to create directory: /

Context:
   service: azfile
   path: 33b8a8d5-0213-4787-a5df-04244e9a6b6a/

We should make it work by normalize the root.

[CookiePieWw]

I'd like to give it a try.

[Xuanwo]

I'd like to give it a try.

Thanks!

[CookiePieWw]

azfile doesn't work if root starts with /

I found here that azure file storage does not have the 'root'.

We should make it work by normalize the root.

Is it appropriate to remove the first / in path while calling the Azure File APIs of reading and writing?

[Xuanwo]

I found here that azure file storage does not have the 'root'.

root is the concept in opendal that we prepend in all our requests, not related to services

Is it appropriate to remove the first / in path while calling the Azure File APIs of reading and writing?

We already performing this via calling build_abs_path. The root cause need to find out.

[Xuanwo]

This issue seems silently fixed by #3651 and #3652

Not reproduced again.

[CookiePieWw]

This issue seems silently fixed by #3651 and #3652

Not reproduced again.

Got it. I'll close the PR. Here are some observations may be useful:

The error message is failed to create directory: / while test_stat_dir. With setting /opendal/ as the root, the failed request sent to azure file storage may be

"https://{accountname}.file.core.windows.net/{sharename}/opendal/?restype=directory"

But before or after the patch mentioned above, the request is actually the same. I think it more likely that the failure is caused by azure file storage REST APIs.

[Xuanwo]

Thanks to @CookiePieWw for the research!