Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of nuclei #479

Closed
1 task done
Xuanwo opened this issue Jul 30, 2022 · 4 comments
Closed
1 task done

Maintenance of nuclei #479

Xuanwo opened this issue Jul 30, 2022 · 4 comments
Assignees

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jul 30, 2022

nuclei seem cool, but I have concerns with its maintenance status. It's better to replace with a more well-maintained io runtime for opendal.

monoio

https://github.com/bytedance/monoio

Good

Both io-uring and mio are supported.

Bad

glommio

https://github.com/DataDog/glommio

Good

  • OK, with stable rust

Bad

  • CI kept failing and no one take care
  • Latest version is 6 months ago
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 30, 2022

cc @PsiACE

@PsiACE PsiACE self-assigned this Jul 30, 2022
@PsiACE
Copy link
Member

PsiACE commented Jul 30, 2022

I will be doing some research to determine what is a more appropriate option. The io-uring-based runtime does not look any more attractive than the io-uring-based io.

Let's go faster, and faster.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 1, 2022

Benchmark after switching to nuclei: https://docs.google.com/spreadsheets/d/1fGZQHCGWNn5uUZkXY6rhBZwCqthRuIYuUq4HMPb3W5k/edit#gid=0

Ontime with 200,000,000 records.

  Before After
Q1 0.204 0.19
Q2 0.263 0.275
Q3 0.45 0.465
Q4 0.154 0.164
Q5 0.159 0.177
Q6 0.468 0.483
Q7 0.441 0.47
Q8 0.633 0.623
Q9 0.35 0.372
Q10 0.58 0.58
Q11 0.62 0.607
Q12 5.301 5.112
Q13 1.929 1.958
Q14 0.005 0.006

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 2, 2022

nuclei has been removed so far. We will introduce io_uring runtime in the future.

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants