Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: Support for client secret auth against azdls #4943

Open
1 task done
twuebi opened this issue Jul 30, 2024 · 2 comments
Open
1 task done

new feature: Support for client secret auth against azdls #4943

twuebi opened this issue Jul 30, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@twuebi
Copy link

twuebi commented Jul 30, 2024

Feature Description

It seems that azdls-service currently only supports sas / sharedkey / imds auth but it doesn't support the client_secret auth method which would work with app registration / entra id.

Problem and Solution

This feature enables using azdls with microsoft app registration. It should either take care of refreshing / logging in again, e.g. via some background task / checking expiry before issuing a request or expose the means to refresh tokens to the user, e.g. via some Arc<RwLock<Token>> which is exposed on the api.

Additional Context

No response

Are you willing to contribute to the development of this feature?

  • Yes, I am willing to contribute to the development of this feature.
@twuebi twuebi added the enhancement New feature or request label Jul 30, 2024
@twuebi
Copy link
Author

twuebi commented Jul 30, 2024

I've started by opening a PR against reqsign which adds support for client-secret authentication Xuanwo/reqsign#457

@twuebi
Copy link
Author

twuebi commented Sep 17, 2024

Hi @Xuanwo, do you think we could create a reqsign release with client-secret authentication support? We could then continue with the work here in opendal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant