Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python binding release failed #5000

Closed
1 task
Xuanwo opened this issue Aug 13, 2024 · 7 comments
Closed
1 task

Python binding release failed #5000

Xuanwo opened this issue Aug 13, 2024 · 7 comments
Labels
bindings/python bug Something isn't working help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 13, 2024

Describe the bug

https://github.com/apache/opendal/actions/runs/10367226638/job/28698185879

The following warnings were emitted during compilation:

warning: [email protected]: CMAKE environment variable set: cmake
warning: [email protected]: Generating bindings - external bindgen. Platform: armv7-unknown-linux-gnueabihf

error: failed to run custom build command for `aws-lc-sys v0.20.1`
note: To improve backtraces for build dependencies, set the CARGO_PROFILE_RELEASE_BUILD_OVERRIDE_DEBUG=true environment variable to enable debug information generation.

Caused by:
  process didn't exit successfully: `/home/runner/work/opendal/opendal/bindings/python/target/release/build/aws-lc-sys-388626e311f91bd8/build-script-main` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_PREFIX
  cargo:rerun-if-env-changed=AWS_LC_SYS_INTERNAL_BINDGEN
  cargo:rerun-if-env-changed=AWS_LC_SYS_EXTERNAL_BINDGEN
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_ASM
  cargo:rerun-if-env-changed=AWS_LC_SYS_CMAKE_BUILDER
  cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC
  cargo:rerun-if-env-changed=CMAKE
  cargo:rerun-if-env-changed=CMAKE
  cargo:warning=CMAKE environment variable set: cmake
  cargo:warning=Generating bindings - external bindgen. Platform: armv7-unknown-linux-gnueabihf

  --- stderr
  Consider installing the bindgen-cli: `cargo install --force --locked bindgen-cli`
  See our User Guide for more information about bindgen:https://aws.github.io/aws-lc-rs/index.html
  Failure invoking external bindgen! External bindgen command failed.
  thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.20.1/builder/main.rs:469:5:
  aws-lc-sys build failed. Please enable the 'bindgen' feature on aws-lc-rs or aws-lc-sys.For more information, see the aws-lc-rs User Guide: https://aws.github.io/aws-lc-rs/index.html
  stack backtrace:
     0: rust_begin_unwind
     1: core::panicking::panic_fmt
     2: build_script_main::main
     3: core::ops::function::FnOnce::call_once
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
warning: build failed, waiting for other jobs to finish...
💥 maturin failed
  Caused by: Failed to build a native library through cargo
  Caused by: Cargo build finished with "exit status: 101": `env -u CARGO "cargo" "rustc" "--features" "pyo3/extension-module,services-all" "--target" "armv7-unknown-linux-gnueabihf" "--message-format" "json-render-diagnostics" "--manifest-path" "/home/runner/work/opendal/opendal/bindings/python/Cargo.toml" "--release" "--lib" "--" "-C" "link-arg=-s"`
Error: The process '/usr/bin/docker' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1702:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1685:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1579:27)
Error: The process '/usr/bin/docker' failed with exit code 1
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

Steps to Reproduce

Happen during building opendal-python.

Expected Behavior

Build pass.

Additional Context

No response

Are you willing to submit a PR to fix this bug?

  • Yes, I would like to submit a PR.
@Xuanwo Xuanwo added the bug Something isn't working label Aug 13, 2024
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 13, 2024

Hi, @messense, do you have any suggestions for getting it fixed?

@Xuanwo Xuanwo added help wanted Extra attention is needed bindings/python labels Aug 13, 2024
@messense
Copy link
Member

Try enable ring instead of the default aws-lc-rs (which seems to require bindgen) feature in rustls.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 13, 2024

Try enable ring instead of the default aws-lc-rs (which seems to require bindgen) feature in rustls.

We are using reqwest now which should enable ring by default?

@messense
Copy link
Member

Maybe check cargo tree -i aws-lc-rs to see what brings it into dependency graph?

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 15, 2024

Thanks for @messense to find out: blackbeam/mysql_async#304

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 19, 2024

Fixed.

@tisonkun
Copy link
Member

As we use sqlx now, we should be able to revert this comment out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/python bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants