Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Agnostic - determine home dir location #108

Open
pritidesai opened this issue Nov 28, 2018 · 0 comments
Open

Platform Agnostic - determine home dir location #108

pritidesai opened this issue Nov 28, 2018 · 0 comments

Comments

@pritidesai
Copy link
Member

@jthomas discovered wskdeploy was looking for .wskprops file under current directory instead of user's home for 386 version of OS (apache/openwhisk-wskdeploy#1014).

@mrutkows applied a quick fix to unblock @jthomas so that he can continue working on his presentation (apache/openwhisk-wskdeploy#1015).

But in long term, we would like to fix this in right way which is adding it in Go client so that the same functionality can be used by the CLI and also by Whisk Deploy.

We are looking at changing GetPropsFromWskprops located at https://github.com/apache/incubator-openwhisk-client-go/blob/master/whisk/wskprops.go#L162

Add functionality of reading .wskprops path using homedir.Expand() like it done in CLI at https://github.com/apache/incubator-openwhisk-cli/blob/461f94fafe405feb3c664a43f6c117bac4d3c27f/commands/property.go#L402.

After the go client is changed, we need to update Whisk Deploy and CLI to use this functionality from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant