HDDS-10767. Reducing DatanodeDetails in the ContainerLocationCache #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Apr 28, 2024
There was a problem hiding this comment.
@guohao-rosicky Thanks for the patch. For future PRs, please create the dev branch in your fork, not in apache/ozone.
In Kubernetes IP address may change when restarted. Looks like the change in caching has some problem with that (read fails after restart).
|
My problem, I will delete this branch. @adoroszlai Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the Ozone Community Meeting, it was discussed that DiDi company's om often occurs full gc, after jmap, it was found too many DatanodeDetails objects occupy memory, this pr will reduce the generation of DatanodeDetails objects.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10767
How was this patch tested?
UT