Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rethink cassandra-launcher approach #192

Closed
raboof opened this issue Apr 28, 2024 · 2 comments · Fixed by #193 or #206
Closed

rethink cassandra-launcher approach #192

raboof opened this issue Apr 28, 2024 · 2 comments · Fixed by #193 or #206

Comments

@raboof
Copy link
Member

raboof commented Apr 28, 2024

We're using sbt-assembly in an unusual way for cassandra-launcher - I'm not sure sbt-assembly really promised to do what we ask it to do here.

This causes trouble trying to update of sbt-multi-jvm or sbt-assembly.

@raboof
Copy link
Member Author

raboof commented Jun 7, 2024

hmm, this still seems to be brittle, breaking the build when plugins change (e.g. #205)

@raboof raboof reopened this Jun 7, 2024
@Roiocam
Copy link
Member

Roiocam commented Jun 8, 2024

After some digging out in #206, cassandra-launcher has no users to sbt-assembly, but cassandra-bundle is used.

I think the sbt-assembly usage was in the "box", but the launcherbuild was a little problem.

Based on document: https://www.scala-sbt.org/1.x/docs/ Classpaths.html# Unmanaged+vs+managed
, Maybe we don't need to manage uber jar in the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants