Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with github.com/DataDog/zstd #379

Closed
omnilight opened this issue Oct 13, 2020 · 3 comments · Fixed by #385
Closed

Problem with github.com/DataDog/zstd #379

omnilight opened this issue Oct 13, 2020 · 3 comments · Fixed by #385
Labels
help wanted anyone who are interested in could help on it triage/week-43 type/bug

Comments

@omnilight
Copy link
Contributor

Expected behavior

Can use this library with other ones using datadog/zstd dependency

Actual behavior

During compilation I get error like:

case-insensitive import collision: "github.com/datadog/zstd" and "github.com/DataDog/zstd"

Steps to reproduce

  1. Require github.com/datadog/zstd into your project or use some other library requiring it
  2. Try to compile your code

As pulsar-client-go uses github.com/DataDog/zstd as it's import dependency under https://github.com/apache/pulsar-client-go/blob/master/pulsar/internal/compression/zstd_cgo.go, compilation fails.

System configuration

pulsar-client-go: v0.2.0

@wolfstudy
Copy link
Member

@omnilight Maybe we can use github.com/datadog/zstd uniformly, which is more in line with the naming convention of the go community. Are you interested in sending a pull request to fix this issue?

@sijie sijie added help wanted anyone who are interested in could help on it triage/week-43 type/bug labels Oct 22, 2020
@omnilight
Copy link
Contributor Author

@wolfstudy Yes, I'm willing to help, will make PR

@omnilight
Copy link
Contributor Author

@wolfstudy PR is created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted anyone who are interested in could help on it triage/week-43 type/bug
Projects
None yet
3 participants