Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to install v0.3.0 because of zstd #440

Closed
dunglas opened this issue Jan 14, 2021 · 5 comments · Fixed by #465
Closed

Impossible to install v0.3.0 because of zstd #440

dunglas opened this issue Jan 14, 2021 · 5 comments · Fixed by #465

Comments

@dunglas
Copy link

dunglas commented Jan 14, 2021

Expected behavior

It should be possible to install the latest version.

Actual behavior

PR #385 conflicts with other libs depending on github.com/DataDog/zstd. In my project, zstd is a transient dependency of many other open source dependencies, and all the other ones are using github.com/DataDog/zstd. This leads to an installation error:

../../go/pkg/mod/github.com/apache/[email protected]/pulsar/internal/compression/zstd_cgo.go:27:2: case-insensitive import collision: "github.com/datadog/zstd" and "github.com/DataDog/zstd"

Downgrading to v0.2.0 fixes the issue on the short term.

Steps to reproduce

go get -u

@freeznet
Copy link
Contributor

should wait for golang/go#26904 to allow replace like

replace github.com/DataDog/zstd v1.4.6-0.20200617134701-89f69fb7df32 => github.com/datadog/zstd v1.4.6-0.20200617134701-89f69fb7df32

@wuYin
Copy link
Contributor

wuYin commented Feb 2, 2021

I have same issue, from pkg.go.dev statistics, DataDog/zstd is used much more often than datadog/zstd
Reference
https://pkg.go.dev/github.com/DataDog/zstd?tab=importedby
https://pkg.go.dev/github.com/datadog/zstd?tab=importedby (pulsar-client-go is one of those few users)

@tuteng
Copy link
Member

tuteng commented Feb 3, 2021

A temporary solution, if you don't need to use zstd related functions, you can simply replace this file and remove the code related to zstd, for example https://github.com/streamnative/pulsar-beat-output/blob/master/zstd_cgo.go

cp zstd_cgo.go /your-file-path/go/pkg/mod/github.com/apache/[email protected]/pulsar/internal/compression/zstd_cgo.go

@sunpe
Copy link

sunpe commented Feb 7, 2021

mark

@omnilight
Copy link
Contributor

Anyway, data dog had added go.mod file to their library, so I believe, we can update dependency here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants