From e6d4f09c442b61780d0b91e995804a84f4c12b89 Mon Sep 17 00:00:00 2001 From: xiangying <1984997880@qq.com> Date: Fri, 7 Jul 2023 21:41:24 +0800 Subject: [PATCH] [fix][test] Fix test `testThreadSwitchOfZkMetadataStore` --- .../pulsar/metadata/MetadataStoreTest.java | 22 ++++++++----------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java index d523128457797..3ef298b1e6190 100644 --- a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java +++ b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java @@ -396,24 +396,20 @@ public void testDeleteUnusedDirectories(String provider, Supplier urlSup @DataProvider(name = "conditionOfSwitchThread") public Object[][] conditionOfSwitchThread(){ return new Object[][]{ - {false, false}, - {false, true}, - {true, false}, - {true, true} + {false}, + {true}, + {false}, + {true} }; } @Test(dataProvider = "conditionOfSwitchThread") - public void testThreadSwitchOfZkMetadataStore(boolean hasSynchronizer, boolean enabledBatch) throws Exception { + public void testThreadSwitchOfZkMetadataStore(boolean enabledBatch) throws Exception { final String prefix = newKey(); - final String metadataStoreName = UUID.randomUUID().toString().replaceAll("-", ""); + final String metadataStoreNamePrefix = "metadata-store"; MetadataStoreConfig.MetadataStoreConfigBuilder builder = - MetadataStoreConfig.builder().metadataStoreName(metadataStoreName); - builder.fsyncEnable(false); + MetadataStoreConfig.builder(); builder.batchingEnabled(enabledBatch); - if (!hasSynchronizer) { - builder.synchronizer(null); - } MetadataStoreConfig config = builder.build(); @Cleanup ZKMetadataStore store = (ZKMetadataStore) MetadataStoreFactory.create(zks.getConnectionString(), config); @@ -421,8 +417,8 @@ public void testThreadSwitchOfZkMetadataStore(boolean hasSynchronizer, boolean e final Runnable verify = () -> { String currentThreadName = Thread.currentThread().getName(); String errorMessage = String.format("Expect to switch to thread %s, but currently it is thread %s", - metadataStoreName, currentThreadName); - assertTrue(Thread.currentThread().getName().startsWith(metadataStoreName), errorMessage); + metadataStoreNamePrefix, currentThreadName); + assertTrue(Thread.currentThread().getName().startsWith(metadataStoreNamePrefix), errorMessage); }; // put with node which has parent(but the parent node is not exists).