-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix NPE when updating topic properties #17352
Conversation
Please follow Pulsar Pull Request Naming Convention Guide: https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35 |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you help open a new PR to branch-2.10? There are a lot conflict when cherry-pick directly. @Flowermin |
It' a fix for this PR #17238 (comment), we should also remove the label @Jason918 |
Co-authored-by: bjhuxiaohua <[email protected]>
Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158)
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) (cherry picked from commit 6f8dbc7) * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) (cherry picked from commit 723ad75) * [fix][broker] Fix NPE when update topic properties. ### Motivation In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`. ### Modifications Add an NPE check. (cherry picked from commit 0b02321) * remove release profile * import * Revert "remove release profile" This reverts commit 6bec650. --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) (cherry picked from commit 6f8dbc7) * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) (cherry picked from commit 723ad75) * [fix][broker] Fix NPE when update topic properties. ### Motivation In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`. ### Modifications Add an NPE check. (cherry picked from commit 0b02321) * remove release profile * import * Revert "remove release profile" This reverts commit 6bec650. --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158)
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>
Motivation
The NPE occurs if
p.properties
isnull
when updating topic's properties in #17238 .Documentation
doc-not-needed