Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] fix the non-active bundle clean logic when updating bundles #21017

Closed
wants to merge 1 commit into from

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Aug 17, 2023

Motivation

Pulsar saves all bundles load informations in loadData which contains bundleData,
the broker will update the bundleData by traversing all LocalBrokerData reported by every broker and remove non-active bundles (found in loadData but not in the newest reported LocalBrokerData)

the current removing of non-active happens in the wrong place, see

https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L540-L571

it removes non-active bundle for every broker

Modifications

fix the non-active bundle clean logic when updating bundles.

remove non-active bundle after traverse brokers bundle data

Documentation

  • doc-not-needed

Matching PR in forked repository

PR in forked repository: aloyszhang#18

@github-actions
Copy link

@aloyszhang Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@lifepuzzlefun
Copy link
Contributor

@aloyszhang hi this pr duplicated with #20620 can you help review ? :-)

@aloyszhang
Copy link
Contributor Author

@lifepuzzlefun sure

@aloyszhang
Copy link
Contributor Author

close since duplicate with #20620

@aloyszhang aloyszhang closed this Aug 18, 2023
@aloyszhang aloyszhang deleted the load-balance branch September 11, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants