[fix][fn] Use unified PackageManagement service to download packages #21955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Jan 31, 2024
freeznet
approved these changes
Jan 31, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #21955 +/- ##
============================================
+ Coverage 73.60% 73.64% +0.04%
- Complexity 32411 32495 +84
============================================
Files 1861 1863 +2
Lines 138674 138814 +140
Branches 15182 15216 +34
============================================
+ Hits 102070 102232 +162
+ Misses 28702 28691 -11
+ Partials 7902 7891 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
pushed a commit
that referenced
this pull request
Feb 5, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Feb 20, 2024
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
Mar 4, 2024
…pache#21955) (cherry picked from commit d3b7ca5)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 4, 2024
…pache#21955) (cherry picked from commit d3b7ca5) (cherry picked from commit d58d598)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…pache#21955) (cherry picked from commit d3b7ca5) (cherry picked from commit d58d598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21931
Main Issue: #xyz
PIP: #xyz
Motivation
when function/sink/source is using pulsar packages as the code file, it still use the old way to download it if the
functionsWorkerEnablePackageManagementis falseModifications
Use the "unified PackageManagement service" to download pulsar packages regardless of the
functionsWorkerEnablePackageManagementconfigVerifying this change
Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#23