[fix] [client] Do no retrying for error subscription not found when disabled allowAutoSubscriptionCreation #22078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zifengmo Please add the following content to your PR description and select a checkbox: |
2 tasks
Technoboy-
reviewed
Feb 20, 2024
poorbarcode
approved these changes
Feb 24, 2024
poorbarcode
changed the title
dao-jun
approved these changes
Feb 24, 2024
|
Ah, @zifengmo Could you push a new patch for the master branch ? |
+1 |
15 tasks
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Feb 29, 2024
…isabled allowAutoSubscriptionCreation (apache#22078)
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
Mar 4, 2024
…isabled allowAutoSubscriptionCreation (apache#22078) (cherry picked from commit bbf6ddf)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 4, 2024
…isabled allowAutoSubscriptionCreation (apache#22078) (cherry picked from commit bbf6ddf) (cherry picked from commit 7eec36e)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…isabled allowAutoSubscriptionCreation (apache#22078) (cherry picked from commit bbf6ddf) (cherry picked from commit 7eec36e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21839
Motivation
In scenarios where subscriptions are made via WebSockets and are proxied through a proxy, addressing the issue of non-existent subscriptions causing consumer clients to continuously retry and not being restricted by the number of subscription consumers, can result in excessive consumption of CPU and memory resources by the proxy.
Modifications
When the subscription does not exist and automatic creation is not permitted, no retries are attempted.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: