Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [client] Do no retrying for error subscription not found when disabled allowAutoSubscriptionCreation #22164

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Technoboy-
Copy link
Contributor

Fixes #21839

Motivation

Push #22078 to the master branch.

In scenarios where subscriptions are made via WebSockets and are proxied through a proxy, addressing the issue of non-existent subscriptions causing consumer clients to continuously retry and not being restricted by the number of subscription consumers, can result in excessive consumption of CPU and memory resources by the proxy.

Modifications

When the subscription does not exist and automatic creation is not permitted, no retries are attempted.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@Technoboy-
Copy link
Contributor Author

Cherry-picked to branch-3.0 with #22078

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 29, 2024
@Technoboy- Technoboy- merged commit ccc2ea6 into apache:master Mar 1, 2024
53 of 55 checks passed
@lhotari
Copy link
Member

lhotari commented Mar 4, 2024

@Technoboy- this made BrokerServiceAutoSubscriptionCreationTest.testDynamicConfigurationTopicAutoSubscriptionCreation really flaky, I filed #22188 . Do you have a chance to check that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The consumer clients created by the Proxy using the WebSocket protocol may cause request blocking.
4 participants