Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local SyncStatSet will not sync to remote value with a same epoch. #6342

Closed
ShannonDing opened this issue Mar 14, 2023 · 6 comments
Closed
Assignees

Comments

@ShannonDing
Copy link
Member

ShannonDing commented Mar 14, 2023

BUG REPORT
When SyncStatSet changes in local, it should be merge to the remote value and then update the epoch.
See the logs below, the local SyncStatSet and the remote have different values with a same epoch.

image

@ShannonDing
Copy link
Member Author

Maybe we should use remote values instead of adding local brokerID to SyncStateSet to update the new sync state.

image

@GenerousMan
Copy link
Contributor

I would like to give it a try, can you assign this issue to me?

@RongtongJin
Copy link
Contributor

image
注意如果都采用远端的值,这个方法需要优化,shrink这里遍历的是已经存在的连接,但此时备连接还没有连上来,导致备没有shrink。

@ShannonDing
Copy link
Member Author

shrink

Try to shrink the sync state set when it is just started.

Copy link

This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.

@github-actions github-actions bot added the stale label Mar 14, 2024
Copy link

This issue was closed because it has been inactive for 3 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants