Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] [ISSUE #7296] [TASK 1] Refector NettyRemotingAbstract with unify future implementation. #7321

Closed
1 task done
Tracked by #7296
drpmma opened this issue Sep 7, 2023 · 0 comments · Fixed by #7322
Closed
1 task done
Tracked by #7296

[Enhancement] [ISSUE #7296] [TASK 1] Refector NettyRemotingAbstract with unify future implementation. #7321

drpmma opened this issue Sep 7, 2023 · 0 comments · Fixed by #7322
Labels
type/enhancement

Comments

@drpmma
Copy link
Contributor

drpmma commented Sep 7, 2023 •
edited
Loading

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

This issue is a sub task of #7296, aim to provide a unify future implementation.

  1. Provide unify future implementation
  2. Add operationSuccess and operationException for interface InvokeCallback.

Motivation

For the convenience of implementing transparent retry.

Describe the Solution You'd Like

Refector NettyRemotingAbstract with unify future implementation.

Describe Alternatives You've Considered

No

Additional Context

No response
This was referenced Sep 7, 2023
Merged
Closed
Closed
drpmma added a commit that referenced this issue Oct 8, 2023
@drpmma
[ISSUE #7321] Refector NettyRemotingAbstract with unify future implem…
8415608 
…entation (#7322)

* Refector NettyRemotingAbstract

* Add invoke with future method

* Deprecate InvokeCallback#operationComplete

* Add operationSuccess and operationException for InvokeCallback

* fix unit test

* fix unit test

* Keep InvokeCallback#operationComplete

* Optimize invokeAsyncImpl operationComplete

* Add unit test for NettyRemotingClient

* fix checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #7321] Refector NettyRemotingAbstract with unify future implementation drpmma/rocketmq
1 participant
@drpmma