Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Git rid of internal sun.nio.ch.DirectBuffer #7551

Closed
1 task done
lizhanhui opened this issue Nov 10, 2023 · 0 comments · Fixed by #7550
Closed
1 task done

[Enhancement] Git rid of internal sun.nio.ch.DirectBuffer #7551

lizhanhui opened this issue Nov 10, 2023 · 0 comments · Fixed by #7550
Labels
type/enhancement

Comments

@lizhanhui
Copy link
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Remove dependency on sun.nio.ch.DirectBuffer

Motivation

Get rid of dependency on sun.nio.ch.DirectBuffer, making codebase JDK 9+ compatible

Describe the Solution You'd Like

Reuse assets from netty

Describe Alternatives You've Considered

Repeat work offered by netty

Additional Context

No response
@lizhanhui lizhanhui mentioned this issue Nov 10, 2023
Merged
lizhanhui added a commit that referenced this issue Nov 13, 2023
@lizhanhui
[ISSUE #7551] Reuse helper methods from Netty to free direct byte buf…
1be5ebc 
…fer (#7550)

* Reuse helper methods from Netty to free direct byte buffer, making codebase JDK 9+ compatible

Signed-off-by: Li Zhanhui <[email protected]>

* Guard against null

Signed-off-by: Li Zhanhui <[email protected]>

* fix #7552

Signed-off-by: Li Zhanhui <[email protected]>

---------

Signed-off-by: Li Zhanhui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #7551] Reuse helper methods from Netty to free direct byte buffer apache/rocketmq
1 participant
@lizhanhui