Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] when isPopShouldStop hit，queueLockManager will not release rightly #8601

Closed
3 tasks done
leizhiyuan opened this issue Aug 29, 2024 · 0 comments · Fixed by #8602
Closed
3 tasks done

[Bug] when isPopShouldStop hit，queueLockManager will not release rightly #8601

leizhiyuan opened this issue Aug 29, 2024 · 0 comments · Fixed by #8602

Comments

@leizhiyuan
Copy link
Contributor

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

any

RocketMQ version

develop

JDK Version

No response

Describe the Bug

whern isPopShouldStop hit, we should release the lock

Steps to Reproduce

review the code

What Did You Expect to See?

review the code

What Did You See Instead?

review the code

Additional Context

No response
@leizhiyuan leizhiyuan mentioned this issue Aug 29, 2024
Merged
lizhanhui added a commit that referenced this issue Aug 30, 2024
@leizhiyuan @lizhanhui
[ISSUE #8601]When isPopShouldStop hit,unlock queueLockManager (#8602)
1a15729 
* fix:when isPopShouldStop hit， unlock queueLockManager

* fix:when isPopShouldStop hit， unlock queueLockManager

* fix: limit rate of appending commit in case of DLedger commit-log

Signed-off-by: Zhanhui Li <[email protected]>

---------

Signed-off-by: Zhanhui Li <[email protected]>
Co-authored-by: Zhanhui Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #8601]When isPopShouldStop hit,unlock queueLockManager leizhiyuan/rocketmq
1 participant
@leizhiyuan