Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5714] Fix the issue that broker can't work normally when transientStorePool=true in controller mode #5722

Merged
merged 15 commits into from
Jan 1, 2023

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

Close #5714
Fix the issue that the slave role does not initialize the transient pool in controller mode

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codestyle not pass

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TransientStorePool Unused import needs to remove. the code style check not pass

@RongtongJin RongtongJin added the progress/wip Work in progress. Accept or refused to be continue. label Dec 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #5722 (e3693a5) into develop (3effd04) will decrease coverage by 0.01%.
The diff coverage is 20.75%.

@@              Coverage Diff              @@
##             develop    #5722      +/-   ##
=============================================
- Coverage      42.39%   42.37%   -0.02%     
- Complexity      8225     8227       +2     
=============================================
  Files           1060     1060              
  Lines          73364    73384      +20     
  Branches        9601     9605       +4     
=============================================
- Hits           31099    31096       -3     
- Misses         38346    38370      +24     
+ Partials        3919     3918       -1     
Impacted Files Coverage Δ
...ocketmq/broker/processor/AdminBrokerProcessor.java 25.28% <0.00%> (ø)
...ache/rocketmq/store/AllocateMappedFileService.java 41.66% <0.00%> (ø)
...ketmq/store/ha/autoswitch/AutoSwitchHAService.java 52.85% <0.00%> (-3.21%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 65.03% <7.14%> (-0.17%) ⬇️
...org/apache/rocketmq/store/DefaultMessageStore.java 52.28% <25.00%> (-0.08%) ⬇️
...ache/rocketmq/store/logfile/DefaultMappedFile.java 43.11% <36.36%> (-0.23%) ⬇️
.../org/apache/rocketmq/store/TransientStorePool.java 23.52% <50.00%> (-2.28%) ⬇️
...ache/rocketmq/store/config/MessageStoreConfig.java 58.68% <100.00%> (+0.16%) ⬆️
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mxsm
mxsm previously approved these changes Dec 21, 2022
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@RongtongJin RongtongJin changed the title [ISSUE #5714] Fix the issue that the slave role does not initialize the transientPool in controller mode [ISSUE #5714] Fix the issue that broker can't work normally when transientStorePool=true in controller mode Dec 22, 2022
@RongtongJin RongtongJin removed the progress/wip Work in progress. Accept or refused to be continue. label Dec 22, 2022
mxsm
mxsm previously approved these changes Dec 26, 2022
caigy
caigy previously approved these changes Dec 27, 2022
@lizhanhui
Copy link
Contributor

Rebase to make CI pass

@odbozhou odbozhou merged commit e1dfc0d into apache:develop Jan 1, 2023
Langkeren pushed a commit to Langkeren/rocketmq that referenced this pull request Jan 3, 2023
…n transientStorePool=true in controller mode (apache#5722)

* Fix the issue that the slave role does not initialize the transientPool in controller mode

* Format the checkstyle

* Remove the useless import

* Fix the HA transmission disconnection issue when transientStorePoolEnable is true

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* Format the check style

* Format the check style
RongtongJin added a commit to RongtongJin/rocketmq that referenced this pull request Jan 10, 2023
…n transientStorePool=true in controller mode (apache#5722)

* Fix the issue that the slave role does not initialize the transientPool in controller mode

* Format the checkstyle

* Remove the useless import

* Fix the HA transmission disconnection issue when transientStorePoolEnable is true

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* Format the check style

* Format the check style
@RongtongJin RongtongJin added the module/ha high availably related label Feb 14, 2023
drpmma pushed a commit that referenced this pull request Feb 21, 2023
…sientStorePool=true in controller mode (#5722)

* Fix the issue that the slave role does not initialize the transientPool in controller mode

* Format the checkstyle

* Remove the useless import

* Fix the HA transmission disconnection issue when transientStorePoolEnable is true

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* just test

* Format the check style

* Format the check style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System busy exception when transientStorePoolEnable=true in controller mode
6 participants