-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #5714] Fix the issue that broker can't work normally when transientStorePool=true in controller mode #5722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codestyle not pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TransientStorePool Unused import needs to remove. the code style check not pass
Codecov Report
@@ Coverage Diff @@
## develop #5722 +/- ##
=============================================
- Coverage 42.39% 42.37% -0.02%
- Complexity 8225 8227 +2
=============================================
Files 1060 1060
Lines 73364 73384 +20
Branches 9601 9605 +4
=============================================
- Hits 31099 31096 -3
- Misses 38346 38370 +24
+ Partials 3919 3918 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
…ol in controller mode
Rebase to make CI pass |
…n transientStorePool=true in controller mode (apache#5722) * Fix the issue that the slave role does not initialize the transientPool in controller mode * Format the checkstyle * Remove the useless import * Fix the HA transmission disconnection issue when transientStorePoolEnable is true * just test * just test * just test * just test * just test * just test * just test * just test * just test * Format the check style * Format the check style
…n transientStorePool=true in controller mode (apache#5722) * Fix the issue that the slave role does not initialize the transientPool in controller mode * Format the checkstyle * Remove the useless import * Fix the HA transmission disconnection issue when transientStorePoolEnable is true * just test * just test * just test * just test * just test * just test * just test * just test * just test * Format the check style * Format the check style
…sientStorePool=true in controller mode (#5722) * Fix the issue that the slave role does not initialize the transientPool in controller mode * Format the checkstyle * Remove the useless import * Fix the HA transmission disconnection issue when transientStorePoolEnable is true * just test * just test * just test * just test * just test * just test * just test * just test * just test * Format the check style * Format the check style
Make sure set the target branch to
develop
What is the purpose of the change
Close #5714
Fix the issue that the slave role does not initialize the transient pool in controller mode
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.