Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the unified remoting logger name. #6042

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

echooymxq
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #6041

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

mxsm
mxsm previously approved these changes Feb 13, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

aaron-ai
aaron-ai previously approved these changes Feb 13, 2023
Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

@echooymxq echooymxq dismissed stale reviews from aaron-ai and mxsm via 759fa84 February 16, 2023 02:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #6042 (9eed0d9) into develop (5a8818b) will increase coverage by 0.01%.
The diff coverage is 42.42%.

@@              Coverage Diff              @@
##             develop    #6042      +/-   ##
=============================================
+ Coverage      43.21%   43.22%   +0.01%     
- Complexity      8840     8847       +7     
=============================================
  Files           1094     1094              
  Lines          77135    77137       +2     
  Branches       10057    10057              
=============================================
+ Hits           33332    33341       +9     
+ Misses         39635    39630       -5     
+ Partials        4168     4166       -2     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/client/impl/MQAdminImpl.java 4.95% <0.00%> (+0.02%) ⬆️
...rg/apache/rocketmq/common/constant/LoggerName.java 0.00% <ø> (ø)
...he/rocketmq/controller/impl/DLedgerController.java 66.49% <ø> (ø)
...tmq/proxy/processor/DefaultMessagingProcessor.java 2.89% <0.00%> (-0.14%) ⬇️
...protocol/http2proxy/Http2ProtocolProxyHandler.java 0.00% <0.00%> (ø)
.../protocol/http2proxy/Http2ProxyBackendHandler.java 0.00% <0.00%> (ø)
...protocol/http2proxy/Http2ProxyFrontendHandler.java 0.00% <0.00%> (ø)
...apache/rocketmq/remoting/common/ServiceThread.java 0.00% <0.00%> (ø)
...e/rocketmq/remoting/protocol/route/BrokerData.java 30.00% <0.00%> (-0.44%) ⬇️
.../org/apache/rocketmq/proxy/config/ProxyConfig.java 44.52% <25.00%> (-0.14%) ⬇️
... and 39 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-ai aaron-ai merged commit 527350d into apache:develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good First Issue log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish the unified remoting logger name.
6 participants