Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6147] Detach RocketmqTraffic from controller_default log #6148

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #6147

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@codecov-commenter
Copy link

Codecov Report

Merging #6148 (78d688f) into develop (c4c3c61) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6148      +/-   ##
=============================================
- Coverage      43.24%   43.20%   -0.04%     
  Complexity      8856     8856              
=============================================
  Files           1094     1094              
  Lines          77146    77146              
  Branches       10060    10060              
=============================================
- Hits           33361    33332      -29     
- Misses         39624    39657      +33     
+ Partials        4161     4157       -4     
Impacted Files Coverage Δ
...n/java/org/apache/rocketmq/test/util/StatUtil.java 15.49% <0.00%> (-14.09%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 80.35% <0.00%> (-5.36%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
.../apache/rocketmq/store/ha/DefaultHAConnection.java 65.86% <0.00%> (-1.21%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 34.53% <0.00%> (-0.56%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 46.82% <0.00%> (-0.30%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 65.13% <0.00%> (-0.11%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.15% <0.00%> (-0.10%) ⬇️
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 63.57% <0.00%> (+0.32%) ⬆️
...q/controller/impl/manager/ReplicasInfoManager.java 61.42% <0.00%> (+0.35%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuz10 yuz10 merged commit 260a21f into apache:develop Feb 21, 2023
mxsm pushed a commit to mxsm/rocketmq that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detach RocketmqTraffic from controller_default log
5 participants