Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6185] Fix It does not take effect when acl is enabled in the proxy #6186

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

fix #6185

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #6186 (d6c2305) into develop (7cfffe7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6186      +/-   ##
=============================================
- Coverage      43.18%   43.16%   -0.03%     
+ Complexity      8852     8848       -4     
=============================================
  Files           1094     1094              
  Lines          77153    77156       +3     
  Branches       10063    10064       +1     
=============================================
- Hits           33321    33305      -16     
- Misses         39665    39677      +12     
- Partials        4167     4174       +7     
Impacted Files Coverage Δ
.../apache/rocketmq/proxy/grpc/GrpcServerBuilder.java 0.00% <0.00%> (ø)
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 80.35% <0.00%> (-5.36%) ⬇️
...tmq/remoting/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...ache/rocketmq/broker/client/ConsumerGroupInfo.java 69.29% <0.00%> (-3.51%) ⬇️
...he/rocketmq/broker/controller/ReplicasManager.java 44.40% <0.00%> (-2.62%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 67.55% <0.00%> (-1.10%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 83.65% <0.00%> (-0.97%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-0.90%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.22% <0.00%> (-0.25%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin
Copy link
Contributor

Hi @Oliverwqcwrw How about fixing the issue in the same way as #5289?

@Oliverwqcwrw
Copy link
Member Author

Hi @Oliverwqcwrw How about fixing the issue in the same way as #5289?

Sounds good :-)

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It does not take effect when acl is enabled in the proxy
4 participants