-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6226] Shutdown flowMonitor when connection disconnect #6227
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6227 +/- ##
=============================================
+ Coverage 43.20% 43.25% +0.05%
+ Complexity 8858 8856 -2
=============================================
Files 1094 1094
Lines 77181 77193 +12
Branches 10069 10070 +1
=============================================
+ Hits 33344 33388 +44
+ Misses 39669 39636 -33
- Partials 4168 4169 +1 ☔ View full report in Codecov by Sentry. |
@guyinyou PTAL~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
controller/src/main/java/org/apache/rocketmq/controller/impl/manager/SyncStateInfo.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Make sure set the target branch to
develop
What is the purpose of the change
fix #6226
Brief changelog
Shutdown flowMonitor when connection disconnect
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.