Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6226] Shutdown flowMonitor when connection disconnect #6227

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

RongtongJin
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #6226

Brief changelog

Shutdown flowMonitor when connection disconnect

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.25%. Comparing base (086f9d1) to head (ab1ec48).
Report is 710 commits behind head on develop.

Files with missing lines Patch % Lines
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 50.00% 1 Missing ⚠️
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6227      +/-   ##
=============================================
+ Coverage      43.20%   43.25%   +0.05%     
+ Complexity      8858     8856       -2     
=============================================
  Files           1094     1094              
  Lines          77181    77193      +12     
  Branches       10069    10070       +1     
=============================================
+ Hits           33344    33388      +44     
+ Misses         39669    39636      -33     
- Partials        4168     4169       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin
Copy link
Contributor Author

@guyinyou PTAL~

guyinyou
guyinyou previously approved these changes Mar 3, 2023
Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

guyinyou
guyinyou previously approved these changes Mar 3, 2023
Copy link
Contributor

@Focus-rth Focus-rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/controller module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a large number of FlowMonitor thread in rocketmq
5 participants