Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6292] fix typos #6293

Merged
merged 6 commits into from
Mar 15, 2023
Merged

[ISSUE #6292] fix typos #6293

merged 6 commits into from
Mar 15, 2023

Conversation

hardyfish
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #6292

Brief changelog

fix typos

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

mxsm
mxsm previously approved these changes Mar 9, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@codecov-commenter
Copy link

Codecov Report

Merging #6293 (00f165b) into develop (9e0fb1b) will increase coverage by 0.00%.
The diff coverage is 41.93%.

@@            Coverage Diff             @@
##             develop    #6293   +/-   ##
==========================================
  Coverage      43.12%   43.12%           
- Complexity      8847     8851    +4     
==========================================
  Files           1095     1094    -1     
  Lines          77279    77249   -30     
  Branches       10082    10082           
==========================================
- Hits           33324    33316    -8     
+ Misses         39782    39761   -21     
+ Partials        4173     4172    -1     
Impacted Files Coverage Δ
...ocketmq/broker/processor/AdminBrokerProcessor.java 25.31% <0.00%> (ø)
...he/rocketmq/client/producer/DefaultMQProducer.java 60.44% <ø> (ø)
.../org/apache/rocketmq/common/utils/ThreadUtils.java 0.00% <0.00%> (ø)
...ools/command/acl/DeleteAccessConfigSubCommand.java 31.70% <0.00%> (ø)
...cketmq/broker/schedule/ScheduleMessageService.java 57.37% <25.00%> (-1.18%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.03% <25.00%> (-0.20%) ⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.76% <57.14%> (+0.53%) ⬆️
...ketmq/client/impl/consumer/PullMessageService.java 48.43% <66.66%> (-0.80%) ⬇️
...pache/rocketmq/acl/plain/PlainAccessValidator.java 78.57% <100.00%> (ø)
...e/rocketmq/broker/topic/TopicRouteInfoManager.java 17.79% <100.00%> (-0.70%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mxsm
mxsm previously approved these changes Mar 9, 2023
@aaron-ai aaron-ai merged commit 94db42a into apache:develop Mar 15, 2023
miles-ton pushed a commit to miles-ton/rocketmq that referenced this pull request Mar 16, 2023
* fix typos

* fix typos

* fix typos
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this pull request Mar 16, 2023
* fix typos

* fix typos

* fix typos
TheR1sing3un pushed a commit to TheR1sing3un/rocketmq that referenced this pull request Mar 17, 2023
* fix typos

* fix typos

* fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix typos
6 participants