Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6346] Support asynchronously notify brokers when their roles has been changed #6348

Conversation

TheR1sing3un
Copy link
Member

  1. support asynchronous notify brokers when roles changed

Make sure set the target branch to develop

What is the purpose of the change

fix #6346

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

1. support asynchronous notify brokers when roles changed
@TheR1sing3un TheR1sing3un changed the title ISSUE[# 6346] support asynchronously notify brokers when their roles has been changed ISSUE[ #6346] support asynchronously notify brokers when their roles has been changed Mar 14, 2023
@RongtongJin RongtongJin changed the title ISSUE[ #6346] support asynchronously notify brokers when their roles has been changed [ISSUE #6346] support asynchronously notify brokers when their roles has been changed Mar 14, 2023
@RongtongJin RongtongJin changed the title [ISSUE #6346] support asynchronously notify brokers when their roles has been changed [ISSUE #6346] Support asynchronously notify brokers when their roles has been changed Mar 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Attention: Patch coverage is 26.82927% with 30 lines in your changes missing coverage. Please review.

Project coverage is 43.00%. Comparing base (fac699e) to head (c11d63a).
Report is 656 commits behind head on develop.

Files with missing lines Patch % Lines
.../apache/rocketmq/controller/ControllerManager.java 25.00% 29 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6348      +/-   ##
=============================================
- Coverage      43.01%   43.00%   -0.02%     
- Complexity      8892     8895       +3     
=============================================
  Files           1103     1103              
  Lines          77763    77839      +76     
  Branches       10126    10134       +8     
=============================================
+ Hits           33453    33477      +24     
- Misses         40118    40168      +50     
- Partials        4192     4194       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RongtongJin
RongtongJin previously approved these changes Mar 14, 2023
…ontrollerManager's constructor method

1. move creating NotifyService instance logic to ControllerManager's
constructor method
@RongtongJin RongtongJin merged commit 52c4c0c into apache:develop Mar 15, 2023
@TheR1sing3un TheR1sing3un deleted the fix_synchronous_call_notifyBrokerRoleChanged branch March 15, 2023 05:50
miles-ton pushed a commit to miles-ton/rocketmq that referenced this pull request Mar 16, 2023
…roles has been changed (apache#6348)

* feat(controller): support asynchronous notify brokers when roles changed

1. support asynchronous notify brokers when roles changed

* refactor(controller): move creating NotifyService instance logic to ControllerManager's constructor method

1. move creating NotifyService instance logic to ControllerManager's
constructor method
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this pull request Mar 16, 2023
…roles has been changed (apache#6348)

* feat(controller): support asynchronous notify brokers when roles changed

1. support asynchronous notify brokers when roles changed

* refactor(controller): move creating NotifyService instance logic to ControllerManager's constructor method

1. move creating NotifyService instance logic to ControllerManager's
constructor method
TheR1sing3un added a commit to TheR1sing3un/rocketmq that referenced this pull request Mar 17, 2023
…roles has been changed (apache#6348)

* feat(controller): support asynchronous notify brokers when roles changed

1. support asynchronous notify brokers when roles changed

* refactor(controller): move creating NotifyService instance logic to ControllerManager's constructor method

1. move creating NotifyService instance logic to ControllerManager's
constructor method
@RongtongJin RongtongJin added module/ha high availably related module/controller labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/controller module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support asynchronously notify brokers when their roles has been changed
3 participants