Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#6342] Fix: Local SyncStatSet sync to remote value when changeToMaster #6352

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

GenerousMan
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix ISSUE #6342

Brief changelog

Local SyncStatSet sync to remote value when changeToMaster

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin RongtongJin self-requested a review March 15, 2023 05:39
@codecov-commenter
Copy link

Codecov Report

Merging #6352 (77893ef) into develop (7485d3c) will increase coverage by 0.04%.
The diff coverage is 22.85%.

@@              Coverage Diff              @@
##             develop    #6352      +/-   ##
=============================================
+ Coverage      43.00%   43.04%   +0.04%     
- Complexity      8892     8902      +10     
=============================================
  Files           1103     1104       +1     
  Lines          77762    77893     +131     
  Branches       10123    10139      +16     
=============================================
+ Hits           33439    33527      +88     
- Misses         40126    40156      +30     
- Partials        4197     4210      +13     
Impacted Files Coverage Δ
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 15.97% <0.00%> (-0.11%) ⬇️
...ocketmq/broker/processor/AdminBrokerProcessor.java 25.27% <0.00%> (-0.02%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 48.92% <ø> (-9.67%) ⬇️
...emoting/protocol/body/ElectMasterResponseBody.java 0.00% <0.00%> (ø)
.../remoting/protocol/body/RoleChangeNotifyEntry.java 0.00% <0.00%> (ø)
...l/header/controller/ElectMasterResponseHeader.java 0.00% <ø> (ø)
...ketmq/store/ha/autoswitch/AutoSwitchHAService.java 57.25% <0.00%> (-1.15%) ⬇️
...he/rocketmq/broker/controller/ReplicasManager.java 43.29% <75.00%> (-1.26%) ⬇️
...q/controller/impl/manager/ReplicasInfoManager.java 65.04% <100.00%> (+0.69%) ⬆️

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 63a014b into apache:develop Mar 16, 2023
miles-ton pushed a commit to miles-ton/rocketmq that referenced this pull request Mar 16, 2023
…er (apache#6352)

* fix ISSUE#6342

* refactor

* correct the syncStateSet in elect process.

* move syncStateSet into request/response's body.

* optimize the broker electing switch's branch.
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this pull request Mar 16, 2023
…er (apache#6352)

* fix ISSUE#6342

* refactor

* correct the syncStateSet in elect process.

* move syncStateSet into request/response's body.

* optimize the broker electing switch's branch.
@RongtongJin RongtongJin added module/ha high availably related module/controller labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/controller module/ha high availably related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants