Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6858] passing through ProxyContext for future expansion #6859

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented Jun 6, 2023

Which Issue(s) This PR Fixes

Fixes #6858

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #6859 (40314b6) into develop (bee5077) will decrease coverage by 0.01%.
The diff coverage is 52.08%.

@@              Coverage Diff              @@
##             develop    #6859      +/-   ##
=============================================
- Coverage      42.65%   42.64%   -0.01%     
+ Complexity      9093     9086       -7     
=============================================
  Files           1121     1121              
  Lines          79775    79775              
  Branches       10409    10409              
=============================================
- Hits           34027    34024       -3     
- Misses         41462    41473      +11     
+ Partials        4286     4278       -8     
Impacted Files Coverage Δ
...proxy/grpc/v2/consumer/ReceiveMessageActivity.java 73.41% <0.00%> (ø)
...tmq/proxy/processor/DefaultMessagingProcessor.java 2.89% <0.00%> (ø)
...rocketmq/proxy/processor/TransactionProcessor.java 60.00% <0.00%> (ø)
.../rocketmq/proxy/service/ClusterServiceManager.java 0.00% <0.00%> (ø)
...q/proxy/service/message/ClusterMessageService.java 11.66% <0.00%> (ø)
...q/proxy/service/metadata/LocalMetadataService.java 0.00% <ø> (ø)
...proxy/service/relay/AbstractProxyRelayService.java 17.64% <ø> (ø)
...ocketmq/proxy/service/route/TopicRouteService.java 58.92% <ø> (ø)
...ervice/transaction/AbstractTransactionService.java 82.14% <0.00%> (ø)
...y/service/transaction/LocalTransactionService.java 0.00% <ø> (ø)
... and 14 more

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit a325d14 into apache:develop Jun 6, 2023
@xdkxlk xdkxlk deleted the develop-ctx branch June 6, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Passing through ProxyContext for future expansion
3 participants