Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that the proxy in the cluster mode obtains the wrong address of broker #6909

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

gaoyf
Copy link
Contributor

@gaoyf gaoyf commented Jun 15, 2023

Which Issue(s) This PR Fixes

Fixes #6908

Brief Description

Fix the problem that the proxy in the cluster mode obtains the wrong address of broker.

How Did You Test This Change?

I have tested it.

@xdkxlk
Copy link
Contributor

xdkxlk commented Jun 15, 2023

Please fix the problems reported by Checkstyle.

@codecov-commenter
Copy link

Codecov Report

Merging #6909 (ac5ad22) into develop (3dda55e) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##             develop    #6909      +/-   ##
=============================================
+ Coverage      42.59%   42.61%   +0.01%     
- Complexity      9117     9130      +13     
=============================================
  Files           1128     1128              
  Lines          80129    80132       +3     
  Branches       10432    10431       -1     
=============================================
+ Hits           34131    34147      +16     
+ Misses         41716    41699      -17     
- Partials        4282     4286       +4     
Impacted Files Coverage Δ
.../rocketmq/proxy/service/ClusterServiceManager.java 0.00% <0.00%> (ø)
...q/proxy/service/client/ClusterConsumerManager.java 0.00% <0.00%> (ø)
...ervice/sysmessage/AbstractSystemMessageSyncer.java 48.00% <66.66%> (+0.70%) ⬆️
.../proxy/service/route/ClusterTopicRouteService.java 90.00% <100.00%> (+17.27%) ⬆️
...rocketmq/proxy/service/route/MessageQueueView.java 64.70% <100.00%> (+2.20%) ⬆️
...etmq/proxy/service/sysmessage/HeartbeatSyncer.java 68.04% <100.00%> (ø)

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit 0b76f6f into apache:develop Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The proxy in the cluster mode obtains the wrong address of the broker
4 participants