[ISSUE #7001] Fix IndexOutOfBoundsException when process pop response #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
reviewed
Jul 13, 2023
| // Value of POP_CK is used to determine whether it is a pop retry, | ||
| // cause topic could be rewritten by broker. | ||
| key = ExtraInfoUtil.getStartOffsetInfoMapKey(messageExt.getTopic(), | ||
| messageExt.getProperty(MessageConst.PROPERTY_POP_CK), messageExt.getQueueId()); |
There was a problem hiding this comment.
有点忘了，如果是新版本 client - 低版本 broker 这里是不是可行 @xdkxlk
There was a problem hiding this comment.
看着没问题，低版本broker不会设置ck，这里就通过topic name来判断
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7001