Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7464] Polish the pop logger format #7465

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

joeCarf
Copy link
Contributor

@joeCarf joeCarf commented Oct 16, 2023

Which Issue(s) This PR Fixes

Fixes #7464

Brief Description

How Did You Test This Change?

@joeCarf
Copy link
Contributor Author

joeCarf commented Oct 16, 2023

@RongtongJin hi~, PTAL

Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are similar issues in other parts of this class. Could you help us modify them together?

@joeCarf
Copy link
Contributor Author

joeCarf commented Oct 16, 2023

There are similar issues in other parts of this class. Could you help us modify them together?

of course

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #7465 (df40306) into develop (0f01df4) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##             develop    #7465      +/-   ##
=============================================
- Coverage      42.97%   42.93%   -0.04%     
+ Complexity      9665     9658       -7     
=============================================
  Files           1161     1161              
  Lines          83920    83920              
  Branches       10898    10898              
=============================================
- Hits           36064    36035      -29     
- Misses         43379    43398      +19     
- Partials        4477     4487      +10     
Files Coverage Δ
...he/rocketmq/broker/processor/PopReviveService.java 36.38% <40.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joeCarf
Copy link
Contributor Author

joeCarf commented Oct 16, 2023

There are similar issues in other parts of this class. Could you help us modify them together?

done! PTAL

@RongtongJin RongtongJin merged commit 3a035d7 into apache:develop Oct 16, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Polish the pop logger format
3 participants