Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getBrokerClusterAclConfig from admin and server #7486

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #issue_id

Brief Description

How Did You Test This Change?

@onejimmyboy
Copy link

Why delete this method? How to obtain ACL configuration through the interface after deletion

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #7486 (f77e4b6) into develop (f0f15b5) will increase coverage by 0.05%.
Report is 4 commits behind head on develop.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #7486      +/-   ##
=============================================
+ Coverage      42.93%   42.99%   +0.05%     
- Complexity      9660     9664       +4     
=============================================
  Files           1161     1158       -3     
  Lines          83930    83858      -72     
  Branches       10898    10889       -9     
=============================================
+ Hits           36038    36053      +15     
+ Misses         43410    43334      -76     
+ Partials        4482     4471      -11     
Files Coverage Δ
...ocketmq/broker/processor/AdminBrokerProcessor.java 23.78% <ø> (+0.19%) ⬆️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 22.90% <ø> (-0.37%) ⬇️
...apache/rocketmq/remoting/protocol/RequestCode.java 0.00% <ø> (ø)
...apache/rocketmq/tools/admin/DefaultMQAdminExt.java 29.12% <ø> (+0.15%) ⬆️
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 24.94% <ø> (+0.02%) ⬆️
.../apache/rocketmq/tools/command/MQAdminStartup.java 0.00% <ø> (ø)
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.37% <0.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin
Copy link
Contributor Author

Why delete this method? How to obtain ACL configuration through the interface after deletion

Suggested to check on the corresponding broker machine

@onejimmyboy
Copy link

onejimmyboy commented Oct 23, 2023

Why delete this method? How to obtain ACL configuration through the interface after deletion

Suggested to check on the corresponding broker machine

Yes, this is indeed possible. But I want to know, what are the reasons for doing this? Why delete it? thanks

Copy link
Contributor

@GenerousMan GenerousMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -80,8 +80,6 @@ public class RequestCode {

public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG = 53;

public static final int GET_BROKER_CLUSTER_ACL_CONFIG = 54;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we reserve the request code to avoid duplication in the future?

caigy
caigy previously approved these changes Oct 24, 2023
Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 38d2676 into apache:develop Oct 24, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants