Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation in broker container configure updating command #7587

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Brief Description

Add validation in broker container configure updating command

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (e955e43) 43.17% compared to head (26d8e17) 43.16%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...e/rocketmq/container/BrokerContainerProcessor.java 40.00% 12 Missing ⚠️
...a/org/apache/rocketmq/common/ControllerConfig.java 0.00% 2 Missing ⚠️
.../apache/rocketmq/common/namesrv/NamesrvConfig.java 0.00% 2 Missing ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7587      +/-   ##
=============================================
- Coverage      43.17%   43.16%   -0.02%     
  Complexity      9780     9780              
=============================================
  Files           1162     1162              
  Lines          84303    84370      +67     
  Branches       10949    10954       +5     
=============================================
+ Hits           36396    36416      +20     
- Misses         43386    43429      +43     
- Partials        4521     4525       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShannonDing ShannonDing merged commit 430ee0a into apache:develop Nov 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants