[ISSUE #8092] Fixed non-idempotent test #8093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8092
Brief Description
The test
org.apache.rocketmq.filter.FilterSpiTest#testRegister
is non-idempotent, as it passes in the first run but fails in the second run in the same JVM. The test fails in subsequent runs in the same environment because it registers aNothingFilter
without unregistering it. The repeated run will then throw aFilter already exist
error. A fix is recommended as unit tests shall be idempotent, and state pollution shall be mitigated so that newly introduced tests do not fail in the future due to polluted shared states.Failure Message in the 2nd Run:
How Did You Test This Change?
Unset
NothingFilter
before exiting the test. All tests pass and are idempotent after the fix.