Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8118] Remove redundant mod in client #8119

Merged
merged 1 commit into from
May 14, 2024

Conversation

miles-ton
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8118

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.85%. Comparing base (159a603) to head (64afe85).

Files Patch % Lines
...rocketmq/client/impl/factory/MQClientInstance.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8119      +/-   ##
=============================================
- Coverage      42.94%   42.85%   -0.10%     
+ Complexity     10387    10371      -16     
=============================================
  Files           1270     1270              
  Lines          88694    88693       -1     
  Branches       11401    11401              
=============================================
- Hits           38092    38005      -87     
- Misses         45914    45992      +78     
- Partials        4688     4696       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin
Copy link
Contributor

LGTM

@lizhimins lizhimins changed the title [ISSUE #8118] remove redundant mod [ISSUE #8118] Remove redundant mod May 14, 2024
@lizhimins lizhimins changed the title [ISSUE #8118] Remove redundant mod [ISSUE #8118] Remove redundant mod in client May 14, 2024
@lizhimins lizhimins merged commit 502e2d7 into apache:develop May 14, 2024
10 checks passed
@miles-ton miles-ton deleted the remove_mod branch May 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] remove redundant mod
6 participants