Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8136] Replace with createProcessQueue and remove createProce… #8139

Merged
merged 1 commit into from
May 15, 2024
Merged

[ISSUE #8136] Replace with createProcessQueue and remove createProce… #8139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ private boolean updateProcessQueueTableInRebalance(final String topic, final Set
}

this.removeDirtyOffset(mq);
ProcessQueue pq = createProcessQueue(topic);
ProcessQueue pq = createProcessQueue();
pq.setLocked(true);
long nextOffset = this.computePullFromWhere(mq);
if (nextOffset >= 0) {
Expand Down Expand Up @@ -779,8 +779,6 @@ public boolean removeUnnecessaryPopMessageQueue(final MessageQueue mq, final Pop

public abstract PopProcessQueue createPopProcessQueue();

public abstract ProcessQueue createProcessQueue(String topicName);

public void removeProcessQueue(final MessageQueue mq) {
ProcessQueue prev = this.processQueueTable.remove(mq);
if (prev != null) {
Expand Down
3 changes: 0 additions & 3 deletions client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceLitePullImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,4 @@ public PopProcessQueue createPopProcessQueue() {
return null;
}

public ProcessQueue createProcessQueue(String topicName) {
return createProcessQueue();
}
}
4 changes: 0 additions & 4 deletions client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePullImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,4 @@ public PopProcessQueue createPopProcessQueue() {
return null;
}

public ProcessQueue createProcessQueue(String topicName) {
return createProcessQueue();
}

}
5 changes: 0 additions & 5 deletions client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalancePushImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,6 @@ public ProcessQueue createProcessQueue() {
return new ProcessQueue();
}

@Override
public ProcessQueue createProcessQueue(String topicName) {
return createProcessQueue();
}

@Override
public PopProcessQueue createPopProcessQueue() {
return new PopProcessQueue();
Expand Down
Loading