Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #6873]If dns resolve controller address exception will update controllerAddresses to null #8180

Merged
merged 11 commits into from
May 24, 2024
Merged

[ISSUE #6873]If dns resolve controller address exception will update controllerAddresses to null #8180

merged 11 commits into from
May 24, 2024

Conversation

weihubeats
Copy link
Member

@weihubeats weihubeats commented May 22, 2024 •
edited
Loading

@weihubeats
Adding null does not update
f79cbe4
@weihubeats
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
0d4e93e 
…develop
@weihubeats
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
b621456 
…develop
@weihubeats
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
35a7d4c 
…develop
@weihubeats
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
199999e 
…develop
@weihubeats
merge
5fbbed2
@weihubeats
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
f52d41e 
…develop
@weihubeats
Merge remote-tracking branch 'apache_master/develop' into weihubeats/…
11f0867 
…develop
@weihubeats
Merge remote-tracking branch 'refs/remotes/apache_master/develop' int…
c930b08 
…o weihubeats/develop
@weihubeats
rolling back
9eb378e
@weihubeats
dns resolution failure not updating controllerAddresses
8d7dad5
@weihubeats
Copy link
Member Author

Let me give you an example, if the normal ip address for dns resolution is 192.168.1.1
After the dns parsing exception, the controller's address should not be updated, should continue to maintain 192.168.1.1, the original return will return an empty List to update the controller address to cause the controller address is empty, this is not reasonable!

@weihubeats
Copy link
Member Author

@RongtongJin @ferrirW

@weihubeats
Copy link
Member Author

I'm very sorry that the previous pr #6873 was closed by me, so please take a look at this latest pr

@weihubeats weihubeats changed the title [ISSUE #8177]optimising update topic from name serve [ISSUE #6873]optimising update topic from name serve May 23, 2024
@weihubeats weihubeats changed the title [ISSUE #6873]optimising update topic from name serve [ISSUE #6873]If dns resolve controller address exception will update controllerAddresses to null May 23, 2024
@RongtongJin RongtongJin merged commit bdc7c0a into apache:develop May 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RongtongJin RongtongJin RongtongJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weihubeats @RongtongJin